Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to event-listener v3.0.0 #43

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Bump to event-listener v3.0.0 #43

merged 1 commit into from
Oct 11, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented May 20, 2023

Testing to make sure that event-listener v3.0.0 actually works before we release smol-rs/event-listener#58

@notgull notgull marked this pull request as draft May 20, 2023 21:36
@notgull
Copy link
Member Author

notgull commented Aug 8, 2023

@zeenix Are you fine with a breaking change? If so I can make Send and Recv !Unpin, which would allow us to not need to box the EventListener and save a heap allocation.

@zeenix
Copy link
Member

zeenix commented Aug 8, 2023

@zeenix Are you fine with a breaking change?

Yes. I'm breaking API in my using crate (zbus) anyway. :)

If so I can make Send and Recv !Unpin, which would allow us to not need to box the EventListener and save a heap allocation.

That would be nice but I suspect a lot of users will want them to be Unpin. Can we provide API to created Pin<Box<..>> to make the transition easier?

src/lib.rs Outdated Show resolved Hide resolved
@notgull notgull marked this pull request as ready for review September 13, 2023 01:22
@notgull notgull requested a review from zeenix September 20, 2023 05:09
src/lib.rs Show resolved Hide resolved
@notgull
Copy link
Member Author

notgull commented Oct 8, 2023

@zeenix Any chance you can review this?

src/lib.rs Show resolved Hide resolved
Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull merged commit 0a7289a into master Oct 11, 2023
6 checks passed
@notgull notgull deleted the notgull/evl-v3.0.0 branch October 11, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants